Skip to content

Add 's2sConfig.syncTimeout' option#3424

Merged
fowler446 merged 2 commits intoprebid:masterfrom
dgirardi:fix-usersync-noload
Jan 6, 2022
Merged

Add 's2sConfig.syncTimeout' option#3424
fowler446 merged 2 commits intoprebid:masterfrom
dgirardi:fix-usersync-noload

Conversation

@dgirardi
Copy link
Contributor

List syncTimeout as s2sConfig option

Code changes: prebid/Prebid.js#7744
Related: prebid/Prebid.js#6354

@muuki88 muuki88 added the LGTM label Nov 22, 2021
| `endpoint` | Required | URL or Object | Defines the auction endpoint for the Prebid Server cluster. See table below for object config properties. |
| `syncEndpoint` | Required | URL or Object | Defines the cookie_sync endpoint for the Prebid Server cluster. See table below for object config properties. |
| `userSyncLimit` | Optional | Integer | Max number of userSync URLs that can be executed by Prebid Server cookie_sync per request. If not defined, PBS will execute all userSync URLs included in the request. |
| `syncTimeout` | Optional | Integer | Maximum number of milliseconds allowed for each userSync to load |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default behaviour is "wait infinitely" right? Maybe this should appear in the docs as well 😄

@dgirardi dgirardi force-pushed the fix-usersync-noload branch from e6c24b0 to 6e75299 Compare November 22, 2021 19:14
Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks dgirardi

@fowler446 fowler446 merged commit 67a420d into prebid:master Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments