Add some missing deprecations for 1.0#383
Conversation
| - `pbjs.allBidsAvailable` | ||
| - `pbjs.buildMasterVideoTagFromAdserverTag` in favor of `pbjs.adServers.dfp.buildVideoUrl` | ||
| - `adUnit.sizeMapping` - see below for [details on sizeConfig]({{site.baseurl}}/dev-docs/prebid-1.0-API.html#size-mapping-changes) | ||
|
|
There was a problem hiding this comment.
$$PREBID_GLOBAL$$.bidderTimeout - Moved to config
prebid/Prebid.js#1633 PR is not merged but it removes
$$PREBID_GLOBAL$$._adsReceived (You already added that)
$$PREBID_GLOBAL$$.timeoutBuffer - Moved to config
$$PREBID_GLOBAL$$.logging - Moved to config
$$PREBID_GLOBAL$$.publisherDomain - Moved to config
$$PREBID_GLOBAL$$.setBidderSequence - Moved to config
$$PREBID_GLOBAL$$.setS2SConfig - Moved to config
There was a problem hiding this comment.
@jaiminpanchal27 what is $$PREBID_GLOBAL$$.bidderTimeout used for? Shouldn't this just be set in requestBids?
There was a problem hiding this comment.
I added pbjs.timeoutBuffer but the rest are covered in the pbjs.setConfig section below this.
jaiminpanchal27
left a comment
jaiminpanchal27
left a comment
There was a problem hiding this comment.
Some more to be added to list. Left a comment
3 participants
@rmloveland @bretg