Skip to content

Fix #3830 and add ESP registerSignalSources docs#3957

Merged
fowler446 merged 1 commit intomasterfrom
add-register-signal-sources
Aug 17, 2022
Merged

Fix #3830 and add ESP registerSignalSources docs#3957
fowler446 merged 1 commit intomasterfrom
add-register-signal-sources

Conversation

@muuki88
Copy link
Contributor

@muuki88 muuki88 commented Aug 12, 2022

🏷 Type of documentation

  • new feature

📋 Checklist

@netlify
Copy link

netlify bot commented Aug 12, 2022

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit 2e90b06
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/62f625b30eb1770008ab8de7
😎 Deploy Preview https://deploy-preview-3957--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@muuki88 muuki88 requested review from dgirardi and patmmccann August 12, 2022 10:05
{: .alert.alert-info :}
To use this function, include the [UserId module](/dev-docs/modules/userId.html) in your Prebid.js build.

This function will register all configured encrypted signals as described in the [UserId module ESP configuration](/dev-docs/modules/userId.html#esp-configurations).
Copy link
Collaborator

@patmmccann patmmccann Aug 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might make sense to list which known signals google will take up

Gam dialogue lists these; one's that are not id providers are not clear what they send

AdColony

Adform ID Fusion

AppLovin

Criteo

Facebook

ID5

Index Exchange

LiveRamp Authenticated Traffic Solution (ATS)

Lotame Panorama ID

OpenX

Parrable

PubMatic

RTB House

SharedID by Prebid.org

Tapjoy

Unified ID 2.0

Vungle

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess a link to the Google docs or the respective ad manager page would be a more reliable source. WDYT?

Copy link
Contributor

@dgirardi dgirardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the feature itself seems harder than normal to use? if this is a gpt-only thing I think we could take care of the call timing in Prebid, maybe if you pass setConfig({userSync: {registerSignalSources: true}}). Could be added as a separate feature if there's demand for it.

@muuki88
Copy link
Contributor Author

muuki88 commented Aug 12, 2022

I thought so as well. We were a bit surprised as prebid usually takes care once a configuration is in place.

Not sure why it was initially implemented this way. I'm not even sure if the check as it's in place at the moment is necessary. The encrypted signal provider array seems like a command queue.

@fowler446 fowler446 merged commit 36f7841 into master Aug 17, 2022
@fowler446 fowler446 deleted the add-register-signal-sources branch August 17, 2022 22:07
ecdrsvc pushed a commit to ecdrsvc/prebid.github.io that referenced this pull request Sep 6, 2023
jlaso pushed a commit to AuDigent/prebid.github.io that referenced this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments