Removing Inmar from Prebid - No longer supported#3985
Closed
prashuc wants to merge 1 commit intoprebid:masterfrom
Closed
Removing Inmar from Prebid - No longer supported#3985prashuc wants to merge 1 commit intoprebid:masterfrom
prashuc wants to merge 1 commit intoprebid:masterfrom
Conversation
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
bretg
suggested changes
Aug 30, 2022
Contributor
bretg
left a comment
bretg
left a comment
There was a problem hiding this comment.
Sorry, we can't let you delete the documentation -- the code is still in the main repo. Please update this PR:
- put a note at the top that says something like "no longer supported"
- add the
enable_download: falseheader. That will take it off the download page - submit a PR to remove the code from the main Prebid.js repo
Author
|
@bretg - updated the PR title (no longer supported). Also we already submitted PR for removing code from main Prebid.js repo (prebid/Prebid.js#8913). |
prashuc
changed the title
Contributor
|
The way we handle adapter removals is that we flag them as not downloadable or supported rather than removing them. Then in a major release (e.g. 8.0), then the docs can be removed. It could be headscratching for a publisher using your adapter to have the docs suddenly disappear. I'm going to close this PR and make one that gives such publishers a transition period. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🏷 Type of documentation
📋 Checklist