Doc native params on mediaTypes (incl. cta)#405
Merged
rmloveland merged 3 commits intomasterfrom Nov 6, 2017
Merged
Conversation
Contributor
Author
|
Code changes here for reference: prebid/Prebid.js#1625 |
mjacobsonny
reviewed
Oct 20, 2017
dev-docs/show-native-ads.md
Outdated
| + `hb_native_cta` | ||
|
|
||
| Note that these keys correspond directly to the `nativeParams` object you define in your ad unit (which is described in more detail below). | ||
| Note that these keys correspond directly to the native object you define in your ad unit (which is [described in more detail below](#native-ad-keys)). |
Contributor
There was a problem hiding this comment.
Let's say "mediaTypes.native" object.
dev-docs/show-native-ads.md
Outdated
|
|
||
| {: .alert.alert-danger :} | ||
| For each native ad unit, all of the bidders within that ad unit must have declared native support in supportedMediaTypes as defined in the adapter's call to registerBidAdapter(). If there are any bidders without native support in a native ad unit, the request won't be made. | ||
| For each native ad unit, all of the bidders within that ad unit must have declared native support in their adapter. If there are any bidders without native support in a native ad unit, the request won't be made. For a list of bidders with native support, see [Bidders with Video and Native Demand]({{site.baseurl}}/bidders.html#bidders-with-video-and-native-demand). |
Contributor
There was a problem hiding this comment.
This doesn't seem to align with observed behavior (and I'm not sure that this should be the expected behavior)
Contributor
Author
There was a problem hiding this comment.
Did some reading of the code and confirmed that the expected behavior is for Prebid to filter out non-native-enabled bidders's bids from native auctions (https://github.com/prebid/Prebid.js/blob/master/src/prebid.js#L399)
Did some testing and am updating the note text to read:
For each native ad unit, all of the bidders within that ad unit must have declared native support in their adapter if you want ads to appear. If there are any bidders without native support in a native ad unit, requests will not be made to those bidders.
Contributor
Author
|
@mjacobsonny I think my latest commits address your feedback - let me know what you think |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope of work here is:
ctafieldmediaTypes: { native ...APILet me know what you think - thanks!