Conversation
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
bretg
changed the title
bretg
left a comment
bretg
left a comment
There was a problem hiding this comment.
Made a couple of small updates that I think will be non-controversial, but you can check the commits for the diffs.
Would rather not have the top-header-providers.png bar chart... that's going to get out of date soon. Where did that graph come from? We should just link there.
I see that other graphs are embeds from sincera...
Would suggest centering the smaller pictures, e.g. the colorful bubble picture and the ad server diagrams. https://thornelabs.net/posts/centering-images-with-jekyll-and-markdown/
|
Thanks @bretg, updates look good. The top header providers also came from Sincera. It was something Mike and I talked about but I don't think he wanted that one dynamic so I just did a screenshot. But I'm fine with taking it out. I'll add the centering, thanks for the link. |
|
Ok - we can leave the picture in for now -- will bring up the conversation with Mike. Once the pictures are centered, will sign off! |
bretg
left a comment
bretg
left a comment
There was a problem hiding this comment.
Looks good - thanks Jean. Am checking with the Sincera folks to make they approve the current treatment.
|
@jeanstemp - a request from Sincera. Please add to the bottom-right of each picture or iframe coming from them. And heads up there may be a change coming to the 'top header providers' static picture |
|
@bretg Thanks for checking on that. I've added the links as requested. |
bretg
left a comment
bretg
left a comment
There was a problem hiding this comment.
@jeanstemp - this PR pretty much removes the entire assets/css/main-bundle.css file. That can't be right?
bretg
left a comment
bretg
left a comment
There was a problem hiding this comment.
What happened is that re-running the SASS-->CSS compilation changed the format of main-bundle.css into a one-line minified version. The change in the number of rows was alarming, but the number of characters is comparable considering the loss of whitespace. Poking around the netlify preview site things look fine.
* Header biddig and Prebid intros * a few tweaks to prebid-intro * tiny tweak to hb-intro * centered images * added links to sincera Co-authored-by: Jean Stemp <jsetmp@prebid.org> Co-authored-by: bretg <bgorsline@gmail.com>
* Header biddig and Prebid intros * a few tweaks to prebid-intro * tiny tweak to hb-intro * centered images * added links to sincera Co-authored-by: Jean Stemp <jsetmp@prebid.org> Co-authored-by: bretg <bgorsline@gmail.com>
2 participants
🏷 Type of documentation
New Intro to Header Bidding and updated/re-written Intro to Prebid
📋 Checklist