Conversation
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
ChrisHuie
approved these changes
Oct 20, 2022
fowler446
reviewed
Oct 21, 2022
| If your bidding endpoint can support more than one biddercode, you shouldn't replicate | ||
| the whole adapter codebase. Rather, follow these steps to create a 'hardcoded' alias: | ||
|
|
||
| 1. Create a config yaml file in static/bidder-info - e.g. static/bidder-info/myalias.yaml |
Contributor
There was a problem hiding this comment.
@bretg Did you mean to have these all labeled as 1? Or should these steps be 1,2,3,4,5?
Contributor
Author
There was a problem hiding this comment.
When jekyll is converted to HTML, it should create an ordered list of this syntax. Setting all lines to 1 is nice in case we want to add one in the middle later on, no need to renumber everything below.
fowler446
approved these changes
Nov 5, 2022
fowler446
reviewed
Nov 5, 2022
|
|
||
| Notes: | ||
| - The alias name must be unique for the first 6 chars as noted above for biddercodes. | ||
| - This process will be simplified someday. |
Contributor
There was a problem hiding this comment.
lol "This process will be simplified someday."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a section on how to create a hardcoded alias in PBS-Go