Adding server response examples#414
Merged
mkendall07 merged 2 commits intoprebid:masterfrom Oct 24, 2017
Merged
Conversation
matthewlane
approved these changes
Oct 24, 2017
Collaborator
matthewlane
left a comment
matthewlane
left a comment
There was a problem hiding this comment.
Looks good, found a typo unrelated, but geographically close to the changes here, noted below
dev-docs/bidder-adapter-1.md
Outdated
| @@ -233,6 +233,10 @@ The `interpretResponse` function will be called when the browser has received th | |||
| // if the bid response was empty or an error, return [] | |||
| // otherwise parse the response and return a bidReponses array | |||
Collaborator
There was a problem hiding this comment.
Just noticed this bidReponses typo, mind sneaking a fix into this PR?
mkendall07
approved these changes
Oct 24, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documenting the changes from prebid/Prebid.js#1748