Add Apester prebid js adapter doc#4629
Merged
muuki88 merged 3 commits intoprebid:masterfrom Jul 6, 2023
Merged
Conversation
added 2 commits
June 7, 2023 00:15
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
9 tasks
9 tasks
muuki88
requested changes
Jun 15, 2023
dev-docs/bidders/apester.md
Outdated
| media_types: video, banner | ||
| userIds: all | ||
| fpd_supported: false | ||
| gdpr_supported: true |
Contributor
There was a problem hiding this comment.
There's no gvl_id and I couldn't find any consent handling in your adapter. How do you support GDPR?
Contributor
Author
There was a problem hiding this comment.
Updated docs, thanks
dev-docs/bidders/apester.md
Outdated
|
|
||
| Apester client-side Prebid.js adapter requires only `host`, `adUnitId`, `adUnitType`. | ||
|
|
||
| Apester client-side Prebid.js adapter supports only `banner` and `video` media types, doesn't support `audio` and `native`. |
Contributor
There was a problem hiding this comment.
This should be covered by the media_types meta data in the header, right?
Contributor
Author
There was a problem hiding this comment.
Updated doc, thanks
Contributor
|
@apykhteyev - please take a look at @muuki88 's items above. |
muuki88
approved these changes
Jul 6, 2023
ecdrsvc
pushed a commit
to ecdrsvc/prebid.github.io
that referenced
this pull request
Sep 6, 2023
* Add Apester prebid js adapter doc * fix * Fix comments --------- Co-authored-by: apykhteyev <alex@project-limelight.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🏷 Type of documentation
📋 Checklist
prebid/Prebid.js#10057