Merged
Conversation
Contributor
|
Hi @jcswart would it be correct to say that these aliases are 1.0-compliant, since the Serverbid adapter is? If so can you please update this PR with the following added line to the YAML at the top of each file? This is used to make sure these adapters show up when you select 1.0 from the dropdown menu on the downloads page. |
Contributor
Author
|
@rmloveland Thank you, was wondering about this! I will make that change now! |
Contributor
Author
|
@rmloveland Changes made, thank you for telling me about this! |
Contributor
Author
|
Let me go ahead and actually add this tag to all of our adapter's yaml as well. |
Contributor
Author
|
Okay, I've included this flag on all of our aliases and added a doc file for an alias that was missing. |
jcswart
force-pushed
the
add-insticator-adsparc
branch
from
d5f23de to
467a4eb
Compare
Contributor
|
Thanks @jcswart - just merged, should be showing up on the site in a few minutes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding documentation for aliases: AdSparc and Insticator.
Should be merged once: prebid/Prebid.js#1802 is accepted.