Merged
Conversation
A few suggestions towards making the document easier to understand, and also adding the "default endpoint" section.
Contributor
|
Relates to prebid/Prebid.js#1904 |
mjacobsonny
reviewed
Dec 7, 2017
dev-docs/prebid-1.0-API.md
Outdated
| "sizeConfig": { ... } | ||
| debug: true, // Previously `logging` | ||
| s2sConfig: { ... }, | ||
| priceGranularit": "medium", |
rmloveland
reviewed
Dec 7, 2017
dev-docs/prebid-1.0-API.md
Outdated
|
|
||
| ## No More Default Endpoints | ||
|
|
||
| In Prebid 0.x there were defaults for the Prebid Server endpoints and the video cache URL. With 1.0, these defaults have been removed to be vendor neutral, so all publisher pages must define them via pbjs.setConfig(). The same functionality as 0.x may be achieved with this setConfig: |
Contributor
There was a problem hiding this comment.
I'd revise the last phrase to "may be achieved as shown below" to avoid using the method name in prose right before just showing a code sample anyway.
rmloveland
reviewed
Dec 7, 2017
|
|
||
| {% endhighlight %} | ||
|
|
||
| ## No More Default Endpoints |
Contributor
There was a problem hiding this comment.
Does this mean the following no longer works as of the 1.0 release?
pbjs.setConfig({
usePrebidCache: true
});
If so there are a lot of video docs that need updating as a result of this change. Looks like this is a result of prebid/Prebid.js#1904 yes?
Contributor
Author
There was a problem hiding this comment.
Right - now it would to be:
pbjs.setConfig({
usePrebidCache: true,
cache: {url: ""}
});
Contributor
Author
|
Made requested changes - @mjacobsonny, @rmloveland |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few suggestions towards making the document easier to understand, and also adding the "default endpoint" section.