Adkernel: removing adliveconnect alias documentation#4856
Merged
bretg merged 3 commits intoprebid:masterfrom Sep 29, 2023
Merged
Adkernel: removing adliveconnect alias documentation#4856bretg merged 3 commits intoprebid:masterfrom
bretg merged 3 commits intoprebid:masterfrom
Conversation
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bretg
reviewed
Sep 18, 2023
Contributor
bretg
left a comment
bretg
left a comment
There was a problem hiding this comment.
thanks for wanting to keep stuff clean @ckbo3hrk , but we don't normally doc files. Publishers often use very old versions of PBJS where these bidders are still available.
Generally what we do is add a flag enable_download: false to the header so it disappears off the download page, and if possible a pbjs_version_notes: field saying something like "removed in 6.0"
We have an open item to support an "archive" page to get them off the main PBJS bidders page.
Contributor
Author
|
@bretg added enable_download & pbjs_version_notes fields |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🏷 Type of documentation
📋 Checklist