Skip to content

Comments

Boldwin: update documentation#4868

Merged
bretg merged 16 commits intoprebid:masterfrom
Wls-demo:master
Sep 19, 2023
Merged

Boldwin: update documentation#4868
bretg merged 16 commits intoprebid:masterfrom
Wls-demo:master

Conversation

@Wls-demo
Copy link
Contributor

🏷 Type of documentation

  • new bid adapter
  • update bid adapter
  • new feature
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

📋 Checklist

  • Related pull requests in prebid.js or server are linked -> Paste link in this list or reference it on the PR itself
  • For new adapters check submitting your adapter docs

@netlify
Copy link

netlify bot commented Sep 18, 2023

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit 582af34
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/6509635b3b2abb00099c4f9e
😎 Deploy Preview https://deploy-preview-4868--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Wls-demo - it's an unusual change to remove a formerly required parameter. What does this statement mean "in case you integrate with Boldwin bidder via an endpoint URL."? Where would such a URL be specified?

Also, note that there are many header fields requested in https://docs.prebid.org/dev-docs/bidder-adaptor.html#submitting-your-adapter missing from this file. Please consider adding as many as possible so publishers are aware of your capabliities.

tcfeu_supported: true/false
gvl_id: none
usp_supported: true/false
coppa_supported: true/false
gpp_supported: true/false
schain_supported: true/false
dchain_supported: true/false
userId: (list of supported vendors)
media_types: banner, video, native
safeframes_ok: true/false
deals_supported: true/false
floors_supported: true/false
fpd_supported: true/false
pbjs: true/false
pbs: true/false
prebid_member: true/false
multiformat_supported: will-bid-on-any, will-bid-on-one, will-not-bid
ortb_blocking_supported: true/partial/false

@bretg bretg added the question label Sep 18, 2023
@Wls-demo
Copy link
Contributor Author

@bretg it was not required parameter. Its required to use one parameter - either placementId or endpointId, but for now we are good to use only endpointId.
Also additional headers fields was added.

@bretg bretg merged commit 8b3ea1d into prebid:master Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants