Conversation
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bretg
changed the title
muuki88
approved these changes
Sep 27, 2023
Contributor
|
@bretg this looks good to me. I can't say too much on the technical details, but I could follow everything and feel confident that if I should ever have the pleasure to implement a custom us consent logic, this would help me get started. Even though I hope this day may never come 😅 |
Co-authored-by: Muki Seiler <muuki88@users.noreply.github.com>
converting table to list
Contributor
Author
|
Thanks for the review @muuki88 . Going to go ahead and merge. Converting the legal warning to an include can happen as a separate PR. |
Contributor
|
Sure thing. Maybe I'll find time tomorrow for refactoring this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.