Microad Bid Adapter: add gpid and other#5140
Closed
kida-yuga wants to merge 1 commit intoprebid:masterfrom
Closed
Conversation
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
9 tasks
Contributor
|
Sorry, no. Publishers cannot be asked to supply gpid, pbadslot, etc as bidder-specific parameters. I see in your javascript code that you're doing the right thing -- the adapter is looking for these values in the right place. They should not be documented as parameters that pubishers need to be aware of. In fact, I'm not fond that you're asking publishers to think about geo, appId, ifa, etc, but will let that go for now since there is a warning about "only effective if provided by MicroAd" Anyhow, I don't think any docs updates are needed at all to cover the reading of these params your adapter's doing. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🏷 Type of documentation
📋 Checklist
For Reviewers
Only 4 other items of gpid were added. Sorry for the large difference due to the alignment of columns.
We have added the following four items.