Skip to content

Comments

Add section on renderer.options#556

Merged
rmloveland merged 1 commit intomasterfrom
outstream-render-options
Feb 8, 2018
Merged

Add section on renderer.options#556
rmloveland merged 1 commit intomasterfrom
outstream-render-options

Conversation

@matthewlane
Copy link
Collaborator

Docs update for prebid/Prebid.js#2025

@rmloveland rmloveland added this to the Prebid 1.3 milestone Feb 1, 2018
@rmloveland
Copy link
Contributor

Hey @matthewlane is my reading of the PR correct, that you pass arbitrary properties to the renderer, so it depends on what the renderer accepts/understands?

Given that, is renderer.options.adText an actual property we should document, or just an example?

@matthewlane
Copy link
Collaborator Author

That's correct, arbitrary properties are passed to the renderer, and it depends on what the renderer understands. AppNexus's renderer does understand adText, but this isn't necessarily a universally understood renderer property. Not sure weather all of the AppNexus properties should be documented or not. If it would be more clear I can change adText to something non-AppNexus specific

@rmloveland
Copy link
Contributor

No need to update, thanks @matthewlane - just want to make sure I understand it so I can eventuallly add to the (eventual) ad unit reference which is still a baby PR here: #558

@rmloveland rmloveland added the LGTM label Feb 8, 2018
@rmloveland rmloveland merged commit a791219 into master Feb 8, 2018
@rmloveland rmloveland deleted the outstream-render-options branch February 8, 2018 15:43
@rmloveland
Copy link
Contributor

Thanks @matthewlane !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants