updates to JSFiddle examples for multiformat updates#577
Conversation
|
Hi @jsnellbaker unfortunately a lot of the updated fiddles don't seem to work, and I'm not sure why. I took screenshots of what's on master vs. what's in this PR, which I'll attach below. It's possible I'm missing something obvious, so please let me know. adjust-price-577.pngadjust-price-master.pngadunit-refresh-577.pngadunit-refresh-master.pngbasic-example-577.pngbasic-example-master.pngbrightcove-577.pngbrightcove-master.pngcustom-price-bucket-577.pngcustom-price-bucket-master.pngcustom-price-bucket-using-setpricegranularity-577.pngcustom-price-bucket-using-setpricegranularity-master.pngfull-page-refresh-577.pngfull-page-refresh-master.png |
|
Hi @rmloveland, I went through the various fiddles and found the issue. These pages were pointing to the legacy 0.34.x branch instead of the current 1.x branch, which contains the functionality to use this new syntax style. I went through all the fiddles again and converted them to the 1.x format and verified they are working again. Note as part of these updates, certain pages had other aspects of the code also updated to the 1.x version of the functionality (such as using Please let me know if you have questions or still see any problems. Thanks. |
rmloveland
left a comment
There was a problem hiding this comment.
LGTM, thanks for all of your work on these updates @jsnellbaker !
* updates to JSFiddle examples for multiformat updates * updating pages with new fiddle that is 1.x compliant * fixing broken fiddle links














As a follow-up to the #528, these are additional updates for the multiformat changes - notably updates to the various JSFiddles used across the dev-docs/examples area of the site.