Add exception support #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenjaminRodenberg
requested review from
BenjaminRodenberg
and removed request for
IshaanDesai
BenjaminRodenberg
approved these changes
Mar 18, 2025
Member
BenjaminRodenberg
left a comment
BenjaminRodenberg
left a comment
There was a problem hiding this comment.
I manually tested how Participant and get_mesh_vertices behaves for faulty input and it looks good to me.
Ideally, we would also test for exceptions in the automated testing. But I do not really see how we can realize this without re-implementing the whole exception mechanism in the mocked preCICE. So let's not do it.
@fsimonis Feel free to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds exception support for the entire API.
Note that both
constandexceptare incompatible, hence I had to remove theconstmember specifiers from the API.This shouldn't be a problem as
constis purely decorative as there is noconstusage in python.This implementation translates all exceptions into
RuntimeErrors on the python side. We could provide a customErroras part of theprecicemodule to make this cleaner.Closes #173