Update installation instructions #230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenjaminRodenberg
added
the
documentation
IshaanDesai
approved these changes
Mar 18, 2025
Member
IshaanDesai
left a comment
IshaanDesai
left a comment
There was a problem hiding this comment.
Looks good 👍 just two minor language-based suggestions from my side.
Co-authored-by: Ishaan Desai <ishaandesai@gmail.com>
fsimonis
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
setup.py installis deprecated and since Ubuntu 24.04 usage of Python venvs is strongly encouraged. Inside of a virtual environment the--useroption is not necessary.We still need to cleanup some other issues related to dependency management, testing and the build process. Let's focus on some obvious problems in the documentation here.