Flatten coordinate array in map_and_read_data
#237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenjaminRodenberg
changed the title
map_and_read_data
Member
|
@r-walloner can you check if the code as provided via this PR works for your script from #236 ? Note: you can also install a dev version of the Python bindings via the following command: See here. |
Contributor
Author
|
@BenjaminRodenberg sry for the long delay. |
IshaanDesai
approved these changes
May 9, 2025
Member
IshaanDesai
left a comment
IshaanDesai
left a comment
There was a problem hiding this comment.
Seems logical to me. If @r-walloner has tested it, I would take it as working.
BenjaminRodenberg
approved these changes
May 13, 2025
Member
BenjaminRodenberg
left a comment
BenjaminRodenberg
left a comment
There was a problem hiding this comment.
Thanks for the contribution and the testing! Looks good to me. I just added a changelog entry and will merge this PR as soon as the CI pipeline has finished.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #236
Note: this change is untested, as I do not have time to set up the project locally right now.