Migrate to pyproject and tox #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsimonis
commented
Jul 3, 2025
fsimonis
commented
Jul 3, 2025
fsimonis
commented
Jul 3, 2025
fsimonis
commented
Jul 3, 2025
fsimonis
commented
Jul 3, 2025
fsimonis
commented
Jul 3, 2025
fsimonis
force-pushed
the
migrate-to-pyproject
branch
from
e8082f1 to
3d90c03
Compare
IshaanDesai
reviewed
Jul 8, 2025
Member
IshaanDesai
left a comment
IshaanDesai
left a comment
There was a problem hiding this comment.
Looks good 👍 There are a few open points, but nothing critical as far as I see.
fsimonis
force-pushed
the
migrate-to-pyproject
branch
from
083c0b7 to
bbe8741
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates from using setup.py and setup.cfg to using pyproject.toml.
It also replaces versioneer with setuptools-git-versioning.
The testing is now handled by tox, which sets an env used by setup.py to determine if it is in a testing environment.
Closes #222
Closes #217
Closes #208
Closes #214
Closes #152
Note regarding #37: wheel build now with
pyproject-build -w