Update requirements.txt #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow for `pyprecice` that are newer than 2.0.
BenjaminRodenberg
approved these changes
Mar 4, 2021
Member
BenjaminRodenberg
left a comment
BenjaminRodenberg
left a comment
There was a problem hiding this comment.
Thanks! Looks good to me. I also tried installing from develop as well as from this branch and observed the same you reported in #90.
You suggested adding the missing digits in the version number. I.e. pyprecice>=2.0.0.0 instead of pyprecice>=2.0. I think that this is optional. We can even write pyprecice>=2, if we want. I don't have a opinion here. I'm fine with any of the solutions above. Feel free to merge this PR either as it is or with a four or single digit version number.
Collaborator
Author
|
Then I will leave it as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for
pypreciceversions that are newer than 2.0. A quick check on my local machine worked out.That is related to #90
Closes #90