-
Notifications
You must be signed in to change notification settings - Fork 158
Add a build step and produce ES6 files. #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| { | ||
| "name": "pretender", | ||
| "version": "2.1.0", | ||
| "version": "3.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took the liberty of bumping the version number since this is a fairly large change to the code base.
| * fullpath: '/mypage?test=yes' | ||
| * } | ||
| */ | ||
| function parseURL(url: string) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TS is working
| @@ -0,0 +1,48 @@ | |||
| import PretenderES from '../src/pretender.es'; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretender imported as a ES6 module. Also not that this test file is a ts file.
| const server = new Pretender(function() {}); | ||
| ``` | ||
| Full example: [use-pretender-as-a-module](https://github.com/givanse/use-pretender-as-a-module) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the repo linked here, I added as collaborators the people that have merge access to Pretender.
Or if you prefer me to delete the mention of 'use-pretender-as-a-module', that is fine, I will.
|
Is there any reason why all of these
must be included in a single PR? I could see this being at least 4
This also has the potential to be a minor release. |
|
you are right, this got too messy, I'll split it up |
|
PR #243
|
This PRs does the following:
pretender.js=>src/index.tspretender.js- this is the IIFE version, it should be working the same as beforepretender.es.js- this one is newmoduleattribute FakeXMLHttpRequest#46I'm still testing this with an actual app, but I think its ready to get reviewed and get a conversation started.done with thatyarn link pretender)