drop Node 4 and 5; add Node 10, 11 #241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 2, 2019
rwjblue
reviewed
Jan 2, 2019
Contributor
rwjblue
left a comment
rwjblue
left a comment
There was a problem hiding this comment.
Can you also add Node 11 (current stable release)?
Member
|
LGTM, pending addition of node 11 |
givanse
force-pushed
the
bump-engines
branch
2 times, most recently
from
e161ad3 to
e0a957c
Compare
givanse
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dropping Node 4 and 5 from CI and adding Node 10, it is the most recent LTS.
Yarn is adding the integrity SHAs for the first time, hence the big diff.