Skip to content

Conversation

@xg-wang
Copy link
Member

@xg-wang xg-wang commented Feb 20, 2020

  • Upgrade devDependencies
  • Drop phantomjs
  • Use yarn and headless Chrome in Travis
  • Remove passthrough request calls jQuery v1 handler test because we are only including single jQuery version.

@xg-wang xg-wang added the dependencies Pull requests that update a dependency file label Feb 20, 2020
@xg-wang xg-wang changed the title Dep Upgrade devDependencies Feb 20, 2020
@xg-wang
Copy link
Member Author

xg-wang commented Feb 20, 2020

Travis is not happy because phantom is used in ci

@xg-wang xg-wang changed the title Upgrade devDependencies Upgrade devDependencies and CI Feb 21, 2020
@xg-wang
Copy link
Member Author

xg-wang commented Feb 21, 2020

CI passes, can I have a review? @trek @stefanpenner

@samselikoff
Copy link
Contributor

I don't know all the details but LGTM + definitely seems an improvement

@xg-wang xg-wang merged commit 6497376 into pretenderjs:master Feb 26, 2020
@xg-wang xg-wang deleted the dep branch February 26, 2020 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file internal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants