Fix passthrough issue for libraries using loadend instead of onreadystatechange (Axios) #355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| export function createPassthrough(fakeXHR, nativeXMLHttpRequest) { | ||
| // event types to handle on the xhr | ||
| var evts = ['error', 'timeout', 'abort', 'readystatechange']; | ||
| var evts = ['error', 'timeout', 'abort', 'readystatechange','loadend']; |
There was a problem hiding this comment.
Suggested change
| var evts = ['error', 'timeout', 'abort', 'readystatechange','loadend']; | |
| var evts = ['error', 'timeout', 'abort', 'readystatechange', 'loadend']; |
|
This looks like a very simple fix to me, can we move forward with it? |
|
Would be great to get this fix in! |
|
I agree with @ailish-mccarthy-lrn, this is such a simple fix that would unblock a lot of people. Lets get it merged 🚀 |
|
Can this be actioned please. This can be a blocker for a lot of products using Axios |
|
Yes please. Currently needing to implement a patch to add this. Would love for this to get merged in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #354 Fixed by adding loadend to the list of events watched by the passthrough