fix: use fastRelativePath when processing ignore paths#83
Open
fix: use fastRelativePath when processing ignore paths#83
fastRelativePath when processing ignore paths#83Conversation
An ignore path can be relative.
For example:
- folder can be `/foo/configs`
- file can be `/foo/src/index.ts`
- the ignore file can be `/foo/configs/.prettierignore`
- the ignore contents can be `../src/index.ts`
This means we end up doing:
```
// does not fall back to path.relative
fastRelativeChildPath('/foo/configs', '/foo/src/index.ts');
```
Which fails since we actually need `fastRelativePath`:
```
// falls back to path.relative
fastRelativePath('/foo/configs', '/foo/src/index.ts');
```
09b2b40 to
3b2a74f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An ignore path can be relative.
For example:
/foo/configs/foo/src/index.ts/foo/configs/.prettierignore../src/index.tsThis means we end up doing:
Which fails since we actually need
fastRelativePath:Fixes #82