check for node_modules and package.json instead of VCS#89
Open
Simomson wants to merge 2 commits intoprettier:mainfrom
Open
check for node_modules and package.json instead of VCS#89Simomson wants to merge 2 commits intoprettier:mainfrom
Simomson wants to merge 2 commits intoprettier:mainfrom
Conversation
Collaborator
|
i imagine the reason it checked for for example, you could run it globally ( so i wonder if we should do both? |
Author
|
fair point, I didn't think of that. I re-added the previous statements, so the PR is now just adding checks for |
43081j
approved these changes
Jan 26, 2026
Collaborator
|
@fabiospampinato can you also take a look at this? 2nd pair of eyes would be good but seems simple enough |
|
I ran into the same issue too, Any update ? The fix looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I also ran into the issue described in #80.
As suggested here, instead of searching for any VCS, we check for the first
node_modulesor apackage.json