fix: directory symlink handling #200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 331f6a9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
JounQin
requested changes
Mar 4, 2025
src/isSupportedExtension.ts
Outdated
| @@ -1,12 +1,22 @@ | |||
| /* eslint-disable unicorn/filename-case */ | |||
|
|
|||
| import { promises as fsp } from 'fs' | |||
Member
There was a problem hiding this comment.
Suggested change
| import { promises as fsp } from 'fs' | |
| import fs from 'fs/promises' |
JounQin
requested changes
Mar 4, 2025
src/isSupportedExtension.ts
Outdated
| * exist, so permit nonexistent files to go through (they appear to be | ||
| * detected by suffix, so never get read). | ||
| */ | ||
| if (stat?.isDirectory()) return false |
Member
There was a problem hiding this comment.
Suggested change
| if (stat?.isDirectory()) return false | |
| if (stat?.isDirectory()) { | |
| return false | |
| } |
JounQin
approved these changes
Mar 4, 2025
Member
JounQin
left a comment
JounQin
left a comment
There was a problem hiding this comment.
LGTM. Thanks for your contribution!
JounQin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix issue 196, and adds tests to verify same. Hopefully the inline comment explains things adequately.
I got complaints about the absence of
simple-git-hooksas well, so added it as a dev-dependency.