Blessing Chusaru - Completed Test Task#21
Open
chusarublessing wants to merge 3 commits intoprimate-inc:masterfrom
Open
Blessing Chusaru - Completed Test Task#21chusarublessing wants to merge 3 commits intoprimate-inc:masterfrom
chusarublessing wants to merge 3 commits intoprimate-inc:masterfrom
Conversation
Contributor
|
Cards:
CTA:
|
Collaborator
|
Hi and thank you for your submission.
|
Author
|
Thank you for your feedback Rafal. Let me sort it out and get back to you.
…On Wed, May 31, 2023, 18:54 Rafal Zielinski ***@***.***> wrote:
Hi and thank you for your submission.
We like your implementation but we want to ask for few tweaks before we
get to the final decision.
1. CTA button should have an icon instead of text chevron, it's also
missing a hover state.
2. CTA text, try using max-width with rem value instead of width: 50%
to limit text width.
3. Card is missing a hover state.
4. Card label is missing color variants
5. Listing could display cards on different screen sizes like 3 > 2 >
1 instead of jumping straight from 3 to 1.
—
Reply to this email directly, view it on GitHub
<#21 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANSY5X7UXOUMWVLJKB34WN3XI5ZUXANCNFSM6AAAAAAYRGF7K4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Author
|
Hie Rafzielinski I have implemented changes as advised. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.