Punctuation.definition.string - Too high priority

[jaymegordo]

I'd like to request that you please remove punctuation.definition.string from the vscode-github theme, and replace it with lower priority values, eg:

• string.quoted.docstring
• string.quoted.single

etc, I'm sure there's a few more.

punctuation.definition.string is just too high priority and overwrites all string punctuation, which prevents further customization. Eg I'd like to be able to set different colors for normal strings vs docstrings (in python).

Overall though amazing theme, thanks!!

[jaymegordo]

Commenting again because I see that 4.0.0 is out now but this hasn't been fixed.

in the ~/.vscode/extensions/github.github-vscode-theme-4.0.0/themes/dark.json file, I'm just commenting out this part and it makes the theme more flexible to define colors for different types of strings.

And this allows me to specify a different colour for strings vs docstrings, which would otherwise all be captured by punctuation.definition.string as it is a higher priority than string.quoted.single or string.quoted.docstring.

docstrings:

normal strings:

[jaymegordo]

Any plans to remove this? would be really appreciated!!

[jaymegordo]

Another github-vscode-theme released 4.2.1 but this hasen't been fixed yet... please please fix thank you!! @simurai

[jaymegordo]

5.0.0 out but still not changed... cmon how hard can this be!! Just break punctuation.definition.string into a couple less high-priority categories??

[jaymegordo]

5.2.2 out now, STILL not fixed please fix thanks!!

[simurai]

Sorry it took so long. punctuation.definition.string should be removed in the next release.

[jaymegordo]

I'm on 6.3.3 and this still exists in dark.json...