Migrate to @primer/primitives v11.3.2 + breaking changes analysis#425
Closed
Migrate to @primer/primitives v11.3.2 + breaking changes analysis#425
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates from @primer/primitives v7.10.0 to v11.3.2, adding 7 accessibility themes. Includes analysis of simplified approach for major version bump.
Changes
Package & Structure
@primer/primitivesto v11.3.2dist/json/colors/*→dist/docs/functional/themes/*.valueproperty vs v7's nested objectsCurrent Implementation (Backward Compatible)
transformToNestedStructure(): Converts v11 flat → v7 nested (260 lines)color.fg.default,scale.blue[6]work as-isBreaking Changes Analysis (For Major Version)
BREAKING_CHANGES_ANALYSIS.md- detailed comparisonsrc/colors-simple.js- 80-line alternative (77% reduction)Comparison:
Result: Current PR works with backward compatibility. Analysis shows 261 lines can be eliminated if breaking changes are acceptable for major version.
New Themes
Total: 16 themes (9 existing + 7 new)
Screenshots
N/A - Theme generation code only, no visual changes to show
Merge checklist
GitHub Light DefaultthemeTake a look at the Contribute section for more information on how test your changes locally.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.