Skip to content

Conversation

@gavinmn
Copy link
Contributor

@gavinmn gavinmn commented Jan 25, 2023

Adds a sparkle icon
CleanShot 2023-01-25 at 09 14 13@2x

@gavinmn gavinmn requested a review from a team as a code owner January 25, 2023 17:14
@gavinmn gavinmn requested a review from colebemis January 25, 2023 17:14
@changeset-bot
Copy link

changeset-bot bot commented Jan 25, 2023

🦋 Changeset detected

Latest commit: a5470ed

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/octicons Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gavinmn gavinmn changed the title Save sparkle-32.svg Save sparkle-16.svg Jan 25, 2023
Copy link
Contributor

@tallys tallys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❇️

@colebemis
Copy link
Contributor

Should this be called sparkle-fill-16 for consistency with the other filled icons?

@gavinmn gavinmn temporarily deployed to github-pages January 25, 2023 18:08 — with GitHub Actions Inactive
@gavinmn gavinmn changed the title Save sparkle-16.svg Save sparkle-fill-16.svg Jan 25, 2023
@gavinmn gavinmn merged commit 4cbc043 into main Jan 25, 2023
@gavinmn gavinmn deleted the add-sparkle branch January 25, 2023 18:54
@primer-css primer-css mentioned this pull request Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants