Skip to content

chore: edited the license link#583

Closed
bravesasha wants to merge 1 commit intoprimev:mainfrom
bravesasha:patch-1
Closed

chore: edited the license link#583
bravesasha wants to merge 1 commit intoprimev:mainfrom
bravesasha:patch-1

Conversation

@bravesasha
Copy link
Copy Markdown

@bravesasha bravesasha commented Jan 25, 2025

the old link was not displayed

ckartik
ckartik suggested changes Jan 27, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@ckartik ckartik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a redundant PR, that replicates existing PR

@ckartik
Copy link
Copy Markdown
Contributor

ckartik commented Jan 27, 2025

Closing for duplicating #578

@ckartik ckartik closed this Jan 27, 2025
@ckartik ckartik added the duplicate This issue or pull request already exists label Jan 27, 2025
@bravesasha
Copy link
Copy Markdown
Author

bravesasha commented Jan 27, 2025

please explain how it can be redundant when the old link gave an error

@chrmatt
Copy link
Copy Markdown
Contributor

chrmatt commented Jan 28, 2025

please explain how it can be redundant when the old link gave an error

The PR #578 fixes the same issue and was submitted before this one. So it is redundant with respect to this other PR.

@bravesasha
Copy link
Copy Markdown
Author

bravesasha commented Jan 29, 2025

please explain how it can be redundant when the old link gave an error

The PR #578 fixes the same issue and was submitted before this one. So it is redundant with respect to this other PR.

thanks for the feedback but my request pool was created 4 days ago and #578 has been a week

@chrmatt
Copy link
Copy Markdown
Contributor

chrmatt commented Jan 29, 2025

please explain how it can be redundant when the old link gave an error

The PR #578 fixes the same issue and was submitted before this one. So it is redundant with respect to this other PR.

thanks for the feedback but my request pool was created 4 days ago and #578 has been a week

And one week is longer than 4 days. What exactly is your question?

@bravesasha
Copy link
Copy Markdown
Author

bravesasha commented Jan 29, 2025

And one week is longer than 4 days. What exactly is your question?

sorry, you're absolutely right, I'm dumb. Have a nice and productive day

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@ckartik ckartik ckartik requested changes

@mrekucci mrekucci mrekucci approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

duplicate This issue or pull request already exists

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bravesasha @ckartik @chrmatt @mrekucci