Conversation
Mikelle
commented
Apr 29, 2025
| t.Run(tc.name, func(t *testing.T) { | ||
| t.Parallel() | ||
| got := u.ComputeResidualAfterDecay(tc.start, tc.end, tc.commit) | ||
| if tc.name == "Commit Very Close To End" { |
Contributor
Author
There was a problem hiding this comment.
@aloknerurkar not sure - why does the computeResidualAfterDecay function use float64 instead of big.Int? Is it because float64 is simpler or faster? If there’s no strong reason, I could refactor the decay calculation to use big.Int.
Contributor
Author
There was a problem hiding this comment.
Otherwise, with current implementation, this test gives flaky result
Collaborator
There was a problem hiding this comment.
We can use big.Int no issues.
aloknerurkar
approved these changes
May 1, 2025
Mikelle
force-pushed
the
fix/change-decay-logic
branch
from
522247e to
a76a527
Compare
aloknerurkar
pushed a commit
that referenced
this pull request
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
If a provider commits to a bid before the decay start time, it counts as fully decayed. It should instead not decay at all in this case. It is also realistic that providers may commit before, especially since we describe in the docs as a good practice for bidders to add ~300 ms to the current time to the start to not have any decay if providers commit "immediately".
Checklist before requesting a review