feat: changed geth library#683
Conversation
Mikelle
force-pushed
the
fix/geth-lib-update
branch
from
7c60af9 to
1e9aa3e
Compare
| signal.Notify(sigc, syscall.SIGINT, syscall.SIGTERM) | ||
| go func() { | ||
| <-sigc | ||
| //nolint:errcheck |
There was a problem hiding this comment.
There's enough //nolint:errcheck in this PR that we should disable that check imo
There was a problem hiding this comment.
we don't have configuration for linter: .golangci.yml
There was a problem hiding this comment.
Can we create one? I don't see the use of adding tens to hundreds of lint exceptions in a PR
There was a problem hiding this comment.
We can't specify, which errcheck we should ignore. I think it's still useful, just not for the .Close functions and fmt.Printf
There was a problem hiding this comment.
Instead of adding the lint ignore we can just add:
_ = fmt.Fprintln()
| signal.Notify(sigc, syscall.SIGINT, syscall.SIGTERM) | ||
| go func() { | ||
| <-sigc | ||
| //nolint:errcheck |
There was a problem hiding this comment.
Instead of adding the lint ignore we can just add:
_ = fmt.Fprintln()
| go 1.23 | ||
| go 1.23.0 | ||
|
|
||
| toolchain go1.24.0 |
There was a problem hiding this comment.
Why is this added?? Why is it using a higher version?
There was a problem hiding this comment.
it was done automatically after geth lib update and go mod tidy
3 participants
Describe your changes
Checklist before requesting a review