Skip to content

feat: implemented member nodes#690

Merged
Mikelle merged 30 commits intomainfrom
feat/member-nodes-single
Jun 4, 2025
Merged

feat: implemented member nodes#690
Mikelle merged 30 commits intomainfrom
feat/member-nodes-single

Conversation

@Mikelle
Copy link
Copy Markdown
Contributor

@Mikelle Mikelle commented May 26, 2025

Describe your changes

Added member nodes for single node consensus. Leader node is saving payloads to the postgres db, and member nodes are polling payload through api from the leader node.

Checklist before requesting a review

  • I have added tests that prove my fix is effective or that my feature works
  • I have made corresponding changes to the documentation

@Mikelle Mikelle self-assigned this May 26, 2025
Base automatically changed from feat/single-node-cl to main May 26, 2025 14:51
Comment thread cl/README.md Outdated

## Running Postgres

We will use Docker Compose to run Redis
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
We will use Docker Compose to run Redis
We will use Docker Compose to run Postgres

@Mikelle Mikelle requested a review from harshsingh1002 May 30, 2025 02:08
Copy link
Copy Markdown
Contributor

@shaspitz shaspitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid, will have to take a deeper look when I have more time. To avoid confusion imo we should replace instances of singlenode with singleleader, since this setup isn't just for a single node anymore, and it's enabling single leader replication

Comment thread cl/README.md Outdated
### Run the Single Node Application
**Leader Node:**

- `SNODE_PRIORITY_FEE_RECIPIENT`
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be more clear to prefix these with LEADER instead of SNODE to match the member node env vars

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@@ -0,0 +1,617 @@
package membernode
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new directory name here could be a bit semantically confusing. This file should probably be in the same directory as the leader's code

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@shaspitz
Copy link
Copy Markdown
Contributor

Also is there a reason we implemented our own solution here instead of using https://www.postgresql.org/docs/current/runtime-config-replication.html#RUNTIME-CONFIG-REPLICATION

@Mikelle
Copy link
Copy Markdown
Contributor Author

Mikelle commented May 31, 2025

Also is there a reason we implemented our own solution here instead of using https://www.postgresql.org/docs/current/runtime-config-replication.html#RUNTIME-CONFIG-REPLICATION

Here it's a bit different mechanism, member nodes don't have their own postgres instances, they are applying payloads to their geth instances

@Mikelle Mikelle merged commit 285774a into main Jun 4, 2025
5 checks passed
@Mikelle Mikelle deleted the feat/member-nodes-single branch June 4, 2025 15:03
harshsingh1002 pushed a commit that referenced this pull request Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants