Conversation
aloknerurkar
approved these changes
Jun 5, 2025
shaspitz
force-pushed
the
fix-reward-manager
branch
from
431e669 to
af408f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
The RewardsManager contract allows any rewards receiver address to set an override address which will then incur rewards on behalf of the receiver. Previously the contract included the option to
migrateExistingRewardsto themsg.senderwhen callingremoveOverrideAddress. This created a vulnerability where a malicious attacker could set any address as the override address, then remove that override address, allowing the attacker to steal funds from anyone.Since this
migrateExistingRewardsflag was originally included only for UX purposes, we can remove it and prevent the described vulnerability.Checklist before requesting a review