Conversation
chrmatt
reviewed
Jun 13, 2025
Contributor
chrmatt
left a comment
chrmatt
left a comment
There was a problem hiding this comment.
The changes look good to me. Note that the overall contract is quite big and I'm not able to verify whether this has some side effects on other parts.
2 tasks
aloknerurkar
approved these changes
Jun 16, 2025
shaspitz
force-pushed
the
vanilla-whitelist
branch
from
32cc241 to
8579035
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
The vanilla registry now requires stakers to be whitelisted by the owner account. This prevents a subset of edge case attack scenarios introduced by the rewards manager.
Corresponding backport PR following our contract upgrade process is here: #699
Checklist before requesting a review