Conversation
kant777
force-pushed
the
feature/cl_get_payload_v4
branch
from
3b38eb0 to
bf8012d
Compare
kant777
force-pushed
the
feature/cl_get_payload_v4
branch
from
70cd46b to
d416143
Compare
aloknerurkar
approved these changes
Jun 25, 2025
Collaborator
aloknerurkar
left a comment
aloknerurkar
left a comment
There was a problem hiding this comment.
Apart from the small comments LGTM
| Usage: "Ethereum address for receiving priority fees (block proposer fee)", | ||
| EnvVars: []string{"LEADER_PRIORITY_FEE_RECIPIENT"}, | ||
| Required: true, | ||
| Value: "0xfA0B0f5d298d28EFE4d35641724141ef19C05684", |
| bb.logger.Debug("newPayload result", | ||
| "status", status.Status, | ||
| "validationError", status.ValidationError, | ||
| "latestValidHash", status.LatestValidHash) |
Collaborator
There was a problem hiding this comment.
nit: Indentation in this case should ideally be
Suggested change
| "latestValidHash", status.LatestValidHash) | |
| "latestValidHash", status.LatestValidHash, | |
| ) |
Improves clarity with line between next control statement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Erigon requires payloads to be v4. And since we are not using the cl code with geth anywhere, it is safe to merge this with main