feat: detect empty blocks by querying pending txes#722
Merged
Conversation
shaspitz
changed the title
Contributor
Author
|
Marking as draft. |
shaspitz
force-pushed
the
empty-blocks-via-rpc
branch
from
aa445c2 to
901517d
Compare
shaspitz
force-pushed
the
empty-blocks-via-rpc
branch
from
901517d to
eb523e3
Compare
kant777
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Previously we were requesting many payloads to be built by the EL without those payloads actually being used. If a payload had no txes in it, we'd throw away that payload and continuously try again. With
LEADER_EVM_BUILD_DELAYset to 1ms and no pending txes, the old logic would request payloads to be rebuilt up to every 1ms.This PR allows created payloads to 1:1 align with sealed blocks using the
txpool_statusjson rpc method. A payload is only built by the EL if there are one or more pending transactions for the node.