fix: remove tech debt in solidity tests #739
Merged
Conversation
shaspitz
commented
Jul 24, 2025
| bidderRegistry.retrieveFunds(nextWindow, commitmentDigest, payable(provider), bidderRegistry.ONE_HUNDRED_PERCENT()); | ||
| } | ||
|
|
||
| function testFail_shouldRetrieveFundsGreaterThanStake() public { |
Contributor
Author
There was a problem hiding this comment.
This test was outdated, it's testing for a revert that no longer happens. See
shaspitz
force-pushed
the
fix-solidity-tests
branch
from
89512ef to
3008961
Compare
shaspitz
commented
Jul 24, 2025
Contributor
|
LGTM! |
kant777
approved these changes
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates our CI to use the latest stable version of forge,
v1.2.3.. This is the default version that's now installed when usingfoundryup.A lot of our tests were failing with the newest version of forge, so they're fixed in this PR. Notably, we had many tests that used the (deprecated)
Fail_*prefix, which was caused them to silently fail, but look like a pass.