fix: tuning bidding logic#742
Merged
aloknerurkar merged 4 commits intomainfrom Jul 26, 2025
Merged
Conversation
chrmatt
approved these changes
Jul 25, 2025
13f57ec to
c444629
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
This is a small fix to estimate the opt in slot correctly. Previously we were not considering the time since the last block in the estimate.
Also in the bidder, we have increased the decay start timestamp delay to 200ms. This is more generous and gives providers some leeway to avoid decay. Also increased the decay time to twice the timeout. Which would make the bid decay atmost to half of its value if provider takes the entire timeout duration to respond. This is still crude but need to give more thought on pricing. Especially since we also need to consider clients which are setting the priority fee on their own.
Issue ticket number and link
Fixes # (issue)
Checklist before requesting a review