feat: add hoodi support to L1 contracts#743
Conversation
| chain_id=17000 | ||
| deploy_contract="DeployHolesky" | ||
| elif [[ "$chain" == "hoodi" ]]; then | ||
| chain_id=23118 |
There was a problem hiding this comment.
I think it's this chain id, correct me if I'm wrong
| chain_id=23118 | |
| chain_id=560048 |
There was a problem hiding this comment.
yeah thats correct I pulled the wrong one and stuck with it
| // address constant public OWNER = 0x1623fE21185c92BB43bD83741E226288B516134a; | ||
|
|
||
| // function run() external { | ||
| // require(block.chainid == 23118, "must deploy on Holesky"); |
There was a problem hiding this comment.
| // require(block.chainid == 23118, "must deploy on Holesky"); | |
| // require(block.chainid == 560048, "must deploy on Hoodi"); |
| } | ||
| } | ||
|
|
||
| // contract DeployHoodi is BaseDeploy { |
There was a problem hiding this comment.
Is there a reason this is all commented out?
There was a problem hiding this comment.
We don't have the registry addresses yet. Will update/uncomment once others are deployed
| address constant public OWNER = 0x1623fE21185c92BB43bD83741E226288B516134a; | ||
|
|
||
| function run() external { | ||
| require(block.chainid == 23118, "must deploy on Hoodi"); |
There was a problem hiding this comment.
same chain id issue as above
| uint256 constant public LST_RESTARKER_DEREG_PERIOD_BLOCKS = 12000; // ~ 1 day | ||
|
|
||
| function run() external { | ||
| require(block.chainid == 23118, "must deploy on Hoodi"); |
| } | ||
| networkMiddlewareService.setMiddleware(mevCommitMiddlewareProxy); | ||
|
|
||
| // No Hoodi Vaults in Symbiotic docs so let's hold off on this |
There was a problem hiding this comment.
lets just delete this commented out code then
…ript fix, logged hoodi deployments in README
7945c84 to
4e324d5
Compare
shaspitz
left a comment
There was a problem hiding this comment.
Approved, just one comment on foundry config
| ast = true | ||
| build_info = true | ||
| extra_output = ["storageLayout"] | ||
| evm_version = 'shanghai' # Change as needed |
There was a problem hiding this comment.
I'd suggest not committing this config to the repo as it's specific to an outdated version of forge
|
|
||
| | Contract | Proxy Address | Initial Commit | | ||
| |-----------------------|----------------------------------------------|---------------------| | ||
| | ValidatorOptInRouter | `0xa380ba6d6083a4Cb2a3B62b0a81Ea8727861c13e` | `13cf068477e6efdbb5c4fe5ce53a11af30bf8b47` in 'main' | |
There was a problem hiding this comment.
I will be creating a new branch for the current release. I think we should use that here.
Describe your changes
-Changed l1-deployer-cli.sh to support the 'hoodi' flag
-Updated validator registry contract deployment scripts to add hoodi support
-Added Symbiotic and Eigenlayer hoodi address constants where possible.
-Deployed new validator registry contracts + opt-in router to Hoodi
-Added new Hoodi deployment address log to README
Issue ticket number and link
Fixes # (issue)
Checklist before requesting a review