Skip to content

feat: add hoodi support to L1 contracts#743

Merged
owen-eth merged 5 commits intomainfrom
hoodi-deployment-functionality
Jul 31, 2025
Merged

feat: add hoodi support to L1 contracts#743
owen-eth merged 5 commits intomainfrom
hoodi-deployment-functionality

Conversation

@owen-eth
Copy link
Copy Markdown
Contributor

@owen-eth owen-eth commented Jul 25, 2025

Describe your changes

-Changed l1-deployer-cli.sh to support the 'hoodi' flag
-Updated validator registry contract deployment scripts to add hoodi support
-Added Symbiotic and Eigenlayer hoodi address constants where possible.
-Deployed new validator registry contracts + opt-in router to Hoodi
-Added new Hoodi deployment address log to README

Issue ticket number and link

Fixes # (issue)

Checklist before requesting a review

  • I have added tests that prove my fix is effective or that my feature works
  • I have made corresponding changes to the documentation

@owen-eth owen-eth requested a review from shaspitz July 25, 2025 23:31
@owen-eth owen-eth changed the title add hoodi support to L1 contracts feat: add hoodi support to L1 contracts Jul 25, 2025
Comment thread contracts/l1-deployer-cli.sh Outdated
chain_id=17000
deploy_contract="DeployHolesky"
elif [[ "$chain" == "hoodi" ]]; then
chain_id=23118
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's this chain id, correct me if I'm wrong

Suggested change
chain_id=23118
chain_id=560048

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah thats correct I pulled the wrong one and stuck with it

// address constant public OWNER = 0x1623fE21185c92BB43bD83741E226288B516134a;

// function run() external {
// require(block.chainid == 23118, "must deploy on Holesky");
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// require(block.chainid == 23118, "must deploy on Holesky");
// require(block.chainid == 560048, "must deploy on Hoodi");

}
}

// contract DeployHoodi is BaseDeploy {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason this is all commented out?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have the registry addresses yet. Will update/uncomment once others are deployed

address constant public OWNER = 0x1623fE21185c92BB43bD83741E226288B516134a;

function run() external {
require(block.chainid == 23118, "must deploy on Hoodi");
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same chain id issue as above

uint256 constant public LST_RESTARKER_DEREG_PERIOD_BLOCKS = 12000; // ~ 1 day

function run() external {
require(block.chainid == 23118, "must deploy on Hoodi");
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

}
networkMiddlewareService.setMiddleware(mevCommitMiddlewareProxy);

// No Hoodi Vaults in Symbiotic docs so let's hold off on this
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets just delete this commented out code then

Copy link
Copy Markdown
Contributor

@shaspitz shaspitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owen-eth owen-eth marked this pull request as ready for review July 28, 2025 19:01
@owen-eth owen-eth force-pushed the hoodi-deployment-functionality branch from 7945c84 to 4e324d5 Compare July 29, 2025 21:11
@owen-eth owen-eth requested a review from shaspitz July 29, 2025 21:12
Copy link
Copy Markdown
Contributor

@shaspitz shaspitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, just one comment on foundry config

Comment thread contracts/foundry.toml Outdated
ast = true
build_info = true
extra_output = ["storageLayout"]
evm_version = 'shanghai' # Change as needed
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest not committing this config to the repo as it's specific to an outdated version of forge

Comment thread contracts/README.md

| Contract | Proxy Address | Initial Commit |
|-----------------------|----------------------------------------------|---------------------|
| ValidatorOptInRouter | `0xa380ba6d6083a4Cb2a3B62b0a81Ea8727861c13e` | `13cf068477e6efdbb5c4fe5ce53a11af30bf8b47` in 'main' |
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will be creating a new branch for the current release. I think we should use that here.

@owen-eth owen-eth merged commit b0c7e5c into main Jul 31, 2025
5 checks passed
@owen-eth owen-eth deleted the hoodi-deployment-functionality branch July 31, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants