feat: bid expression changes#766
Merged
aloknerurkar merged 24 commits intomainfrom Sep 1, 2025
Merged
Conversation
chrmatt
reviewed
Aug 28, 2025
shaspitz
reviewed
Aug 29, 2025
| hex"" | ||
| ); | ||
|
|
||
| // _testCommitmentAliceBob = TestCommitment( |
Contributor
There was a problem hiding this comment.
We should remove this if intentional
Collaborator
Author
There was a problem hiding this comment.
@owen-eth We also need to adjust the tests in this file to have some sort of dummy options.
shaspitz
reviewed
Aug 29, 2025
shaspitz
reviewed
Aug 29, 2025
| hashStr := hex.EncodeToString(hash) | ||
| // This hash is sourced from the solidity contract to ensure interoperability | ||
| expHash := "8d1f669e1d55329ba0dc133fba063c06c8ae146b8e815732f9951930c807ff7f" | ||
| expHash := "a5b1326e41e48fb9d718700c97771c3518c6127140e53c123431476025066f09" |
Contributor
There was a problem hiding this comment.
Where does this hash come from?
Collaborator
Author
There was a problem hiding this comment.
So this is actually from the contract tests. @owen-eth This needs to be changed as well.
There is a test in the PreconfManager contract which should produce the same values as this test.
https://github.com/primev/mev-commit/blob/main/contracts/test/core/PreconfManagerTest.sol#L87
I tried changing these values but other tests started failing.
aloknerurkar
force-pushed
the
bid-expression
branch
from
b5c6357 to
574ab3d
Compare
chrmatt
reviewed
Aug 29, 2025
aloknerurkar
force-pushed
the
bid-expression
branch
from
f445584 to
b04e8c0
Compare
aloknerurkar
force-pushed
the
bid-expression
branch
from
8056e0f to
e47b565
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Fixes # (issue)
Checklist before requesting a review