fix: incorrect uniqueness constraint on consensus db #786
Merged
Conversation
aloknerurkar
approved these changes
Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR, if the leader CL node were to restart, it would enter a broken state where the resumed payloads were not being saved to the DB because of an incorrect uniqueness constraint on the payload's payloadID. Note payloadID is opaque to the consensus layer and should not be used as a uniqueness identifier. blockNum is the correct uniqueness ID to use for payloads.
I've also removed some debug logs in this PR that were spammy during debugging and are not useful.