Skip to content

perf: optimize get latest height postgres query #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaspitz merged 2 commits into from
Sep 17, 2025
Merged

perf: optimize get latest height postgres query #791

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
137a68b
Update postgres.go
shaspitz Sep 17, 2025
e8ace7a
Update postgres.go
shaspitz Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions cl/singlenode/payloadstore/postgres.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,21 +280,26 @@ func (r *PostgresRepository) GetLatestPayload(ctx context.Context) (*types.Paylo

func (r *PostgresRepository) GetLatestHeight(ctx context.Context) (uint64, error) {
query := `
SELECT MAX(block_height) FROM execution_payloads;
SELECT block_height
FROM execution_payloads
ORDER BY block_height DESC
LIMIT 1;
`
queryCtx, cancel := context.WithTimeout(ctx, 5*time.Second)
defer cancel()

var n sql.NullInt64
if err := r.db.QueryRowContext(queryCtx, query).Scan(&n); err != nil {
// MAX should never return sql.ErrNoRow, always bubble errors
var h int64
err := r.db.QueryRowContext(queryCtx, query).Scan(&h)
if err != nil {
if err == sql.ErrNoRows { // Empty table -> new chain
return 0, nil
}
return 0, err
}
if !n.Valid {
// Empty table -> new chain
return 0, nil
if h < 0 {
return 0, fmt.Errorf("returned block height is negative: %d", h)
}
return uint64(n.Int64), nil
return uint64(h), nil
}

// Close closes the database connection.
Expand Down
Loading