feat: rocketpool registry for minipool operators#813
Merged
Conversation
shaspitz
approved these changes
Oct 2, 2025
owen-eth
added a commit
that referenced
this pull request
Oct 17, 2025
* initial rocketpool registry commit * updated initializer and setters, added go files * fixes and cleanup to minipoolregistry, added tests * added rocketpool deployment script * minor fixes, update l1-deployer to use etherscan v1 api * added testnet deployment to readme * removed modifiers from pause functions
owen-eth
added a commit
that referenced
this pull request
Oct 21, 2025
…manager contracts, vanillaregistry changes (#838) * feat: rocketpool registry for minipool operators (#813) * initial rocketpool registry commit * updated initializer and setters, added go files * fixes and cleanup to minipoolregistry, added tests * added rocketpool deployment script * minor fixes, update l1-deployer to use etherscan v1 api * added testnet deployment to readme * removed modifiers from pause functions * allow Vanilla minstake to equal 0, added tests, reputational deployment script (#832) * update l1 deployment script - removes restrictions for testnet, add support for vanilla reputational (#833) * changed vanilla reputational to 1 eth min stake (#835) * fix: updated hub deployment to not immediately impact optinrouter (#837) * updated hub deployment to not immediately impact optinrouter * removed unused imports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adds a RocketPool validator registry for Mev-Commit. Operators register using validator pubkeys; we read ownership/status from Rocket Pool and only track minimal participation state on our side.
How it works: given a validator pubkey, we resolve pubkey → minipool via RocketStorage, read the node address from the minipool, and verify the minipool is active (“Staking”). We also read the node’s current withdrawal address. A call is authorized if msg.sender is either the node address or the withdrawal address. On success we mark the pubkey as registered in a tiny struct (exists, deregTimestamp, freezeTimestamp).
Key points:
Registration is free (gas only).
Both the node address and the withdrawal address can register, request deregistration, and finalize deregistration.
Freezing functionality similar to AVS Registry: A designated freeze oracle can freeze; unfreezing requires a fee. The fee is fully forwarded to the configured receiver; any overpayment is refunded to the caller; the registry never retains ETH. The owner can unfreeze without a fee.
Deregistration is two-step: request (records a timestamp) then finalize after a configurable period, and only if not frozen. Finalization clears the registration.
“Opted in” is true only when registered, minipool currently active, not frozen, and no pending deregistration.
Batch operations supported for register/freeze/unfreeze/deregister.
Admin controls: freeze oracle, unfreeze fee, unfreeze fee receiver, deregistration period, and RocketStorage address. Contract is pausable and UUPS-upgradeable.
Integration touchpoints (read-only): pubkey → minipool via RocketStorage; node address and status from the minipool; node’s withdrawal address from Rocket Pool. This keeps Rocket Pool as the source of truth for validator ownership/lifecycle while giving Mev-Commit opt-in, freeze policy, and deregistration controls.
Issue ticket number and link
Fixes # (issue)
Checklist before requesting a review