fix: event for manually adding pubkey to provider reg#820
Merged
Conversation
shaspitz
changed the title
shaspitz
changed the title
shaspitz
changed the title
shaspitz
commented
Oct 3, 2025
owen-eth
reviewed
Oct 3, 2025
| } | ||
| } | ||
| delete blockBuilderBLSKeyToAddress[blsPublicKey]; | ||
| emit BLSKeyRemoved(provider, blsPublicKey); |
Contributor
There was a problem hiding this comment.
An event shouldn't be emitted if we don't find the key in the list, could require at the beginning that blockBuilderBLSKeyToAddress[blsPublicKey] is populated
Contributor
There was a problem hiding this comment.
Actually this could cause a different issue in the case of duplicates existing, since if we had this check then only one could be removed, and would fail on the second call. Maybe we want to consider removing all instances of the key?
Contributor
There was a problem hiding this comment.
Other option: add the require statement, but prevent double registration in overrideAddBLSKey() so that duplicates cannot exist in the first place
Contributor
|
missing new abi generation |
rose2221
pushed a commit
that referenced
this pull request
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
overrideAddBLSKeypreviously didn't emit aBLSKeyAddedevent, making the action not easily observable on-chain. This PR adds that event to the function, and also adds a correspondingoverrideRemoveBLSKeyfunction.