fix: fast-track for RPC service#829
Merged
aloknerurkar merged 4 commits intomainfrom Oct 15, 2025
Merged
Conversation
shaspitz
approved these changes
Oct 15, 2025
| EnvVars: []string{"PRECONF_RPC_WEBHOOK_URLS"}, | ||
| } | ||
|
|
||
| optionAuthToken = &cli.StringFlag{ |
Contributor
There was a problem hiding this comment.
Do we need a refresh interval of 1h for the auth token if it's only loaded on startup? Is the token intended to rotate every hour?
Collaborator
Author
There was a problem hiding this comment.
No right now this is not being rotated. But we can rotate by updating AWS secrets which should trigger kubernetes to update the value. But I think the app will need to be restarted as it is configured on start.
Collaborator
Author
There was a problem hiding this comment.
Not yet sure if this is going to be a feature for the long run, so I prefer not having some elaborate JWT scheme for this right now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Allow authenticated API to configure a provider set as a fast track group. If all the providers in the fast track group commit, we will preconfirm the transaction.
Issue ticket number and link
Fixes # (issue)
Checklist before requesting a review